feat: inform user about cli updates - #91
Merged
aviatco merged 14 commits intoJan 5, 2026
Merged
Conversation
Guust Franssens (Guust-Franssens)
requested a review
from a team
as a code owner
December 11, 2025 19:23
7 tasks
aviatco
reviewed
Dec 15, 2025
aviatco
reviewed
Dec 15, 2025
aviatco
reviewed
Dec 23, 2025
Contributor
Author
|
Thanks for the review aviatco. Your points are valid and I will keep them in mind in my potential future PRs. I left some of the remarks open (like proper naming and the class one) as these warrant a second review by you to verify if my changes are meeting your request. |
Guust Franssens (Guust-Franssens)
requested a review
from Alon Yeshurun (ayeshurun)
December 23, 2025 10:43
Guust Franssens (Guust-Franssens)
force-pushed
the
feat/inform-about-user-about-cli-updates
branch
from
December 24, 2025 07:46
ccf89bf to
f506576
Compare
Guust Franssens (Guust-Franssens)
force-pushed
the
feat/inform-about-user-about-cli-updates
branch
from
December 24, 2025 10:00
f4b4c4e to
13acee7
Compare
Contributor
Author
|
aviatco Alon Yeshurun (@ayeshurun) in f4b4c4e I made a change to ignore pypi.org in the VCR playback. This was causing issues in the This passes the tests however now during testing of the fab auth login, actual requests to PyPI are being made. I think it would be cleaner to either:
Could you provide some guidance here? |
aviatco
reviewed
Dec 29, 2025
Fixes auth test failures caused by version check requests not present in existing recordings. PyPI checks are tested separately.
Guust Franssens (Guust-Franssens)
force-pushed
the
feat/inform-about-user-about-cli-updates
branch
from
December 30, 2025 07:41
14742d2 to
e3a65b1
Compare
Guust Franssens (Guust-Franssens)
force-pushed
the
feat/inform-about-user-about-cli-updates
branch
from
December 31, 2025 10:35
2857200 to
b56ef8e
Compare
aviatco
reviewed
Jan 1, 2026
Co-authored-by: aviatco <32952699+aviatco@users.noreply.github.com>
Guust Franssens (Guust-Franssens)
force-pushed
the
feat/inform-about-user-about-cli-updates
branch
from
January 2, 2026 08:15
a5f498d to
b384c46
Compare
aviatco
approved these changes
Jan 4, 2026
Guust Franssens (Guust-Franssens)
deleted the
feat/inform-about-user-about-cli-updates
branch
January 5, 2026 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
✨ Description of new changes
Implements automatic update notifications that inform users when a new version of the Fabric CLI is available on PyPI. The check runs on login (
fab auth login) and displays a friendly notification if an update is available.Changes Made
New Files:
src/fabric_cli/utils/fab_version_check.py- Core version checking module with PyPI integrationtests/test_utils/test_fab_version_check.py- 100% coverage on fab_version_check.pyModified Files:
src/fabric_cli/core/fab_constant.py- Added constants for update checking configurationsrc/fabric_cli/commands/auth/fab_auth.py- Integrated version check on successful logindocs/essentials/settings.md- Documented the newcheck_updatessettingImplementation Details
fab auth loginfab config set check_updates falsefab_loggerfor troubleshootingConfiguration
New config key
check_cli_version_updates(default:true) stored in~/.config/fab/config.json. This setting enables/disables update notifications.User Experience
When a user logs in and a new version is available: